Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: SE Diffs 3.x to Main *.adoc #7515

Merged
merged 21 commits into from
Sep 13, 2023
Merged

Conversation

ljamen
Copy link
Contributor

@ljamen ljamen commented Sep 5, 2023

Description

This PR will capture all of the diffs from 3.x to main in se/docs.
Each commit will reference a different adoc.

Once merged I will update the 4x doc issues indicating that the docs have been updated for diffs.

@ljamen ljamen added docs 4.x Version 4.x labels Sep 5, 2023
@ljamen ljamen added this to the 4.x milestone Sep 5, 2023
@ljamen ljamen self-assigned this Sep 5, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 5, 2023
@ljamen ljamen marked this pull request as draft September 5, 2023 13:24
@ljamen ljamen changed the title DOCS: Diffs 3.x to Main *.adoc DOCS: SE Diffs 3.x to Main *.adoc Sep 8, 2023
@ljamen ljamen marked this pull request as ready for review September 8, 2023 18:53
docs/se/webserver.adoc Outdated Show resolved Hide resolved
docs/se/webserver.adoc Outdated Show resolved Hide resolved
docs/se/webserver.adoc Outdated Show resolved Hide resolved
docs/se/webserver.adoc Outdated Show resolved Hide resolved
docs/se/webserver.adoc Show resolved Hide resolved
@@ -1,6 +1,6 @@
///////////////////////////////////////////////////////////////////////////////

Copyright (c) 2023 Oracle and/or its affiliates.
Copyright (c) 2020, 2023 Oracle and/or its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in file?

@@ -1,6 +1,6 @@
///////////////////////////////////////////////////////////////////////////////

Copyright (c) 2019, 2022 Oracle and/or its affiliates.
Copyright (c) 2019, 2023 Oracle and/or its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only date changed?

@@ -66,7 +71,7 @@ The rest of this section takes you through the process of changing your applicat
. Register an instance of link:{micrometer-javadoc-base-url}/io/helidon/integrations/micrometer/MicrometerSupport.html[`MicrometerSupport`] with the web server.
. Create meters using the meter registry managed by Helidon's `MicrometerSupport` and then update and query those meters.

=== Register an Instance of `MicrometerSupport` with the Web Server
=== Register an Instance of MicrometerSupport with the Web Server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep in ``?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then just split the word?

@@ -127,7 +133,7 @@ You can override these defaults in either of two ways:
* Using the link:{micrometer-javadoc-base-url}/io/helidon/integrations/micrometer/MicrometerSupport.Builder.html[`MicrometerSupport.Builder`] class
* Using configuration

==== Using `MicrometerSupport.Builder`
==== Using MicrometerSupport.Builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as everywhere in the file for code in headers

@@ -156,7 +162,7 @@ MicrometerSupport support = MicrometerSupport.builder()
include::{rootdir}/includes/metrics/micrometer-shared.adoc[tag=overriding-using-config]


=== Enrolling other Micrometer meter registries
=== Enrolling Other Micrometer Meter Registries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"O"ther?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants