[4.x] OciExtension refinements #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
requested changes
Sep 11, 2023
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Sep 11, 2023
| * @see #configSupplier() | ||
| */ | ||
| public static void fallbackConfigSupplier(Supplier<io.helidon.common.config.Config> configSupplier) { | ||
| fallbackConfigSupplier = configSupplier; |
There was a problem hiding this comment.
fallbackConfigSupplier = Objects.requireNonNull(configSupplier, "configSupplier")? (And @exception NullPointerException if {@code configSupplier} is {@code null}.)
tomas-langer
approved these changes
Sep 11, 2023
ljnelson
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7562.
This change, in conjunction with the upcoming work in #7373 will make oci auth integration backwards compatible with 3.x behavior.