Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: demonstrate proper use of GlobalConfig in archetypes #7664

Merged
merged 1 commit into from
Sep 25, 2023
Merged

4.x: demonstrate proper use of GlobalConfig in archetypes #7664

merged 1 commit into from
Sep 25, 2023

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Sep 25, 2023

Description

fix #7628

Documentation

no impact

@tvallin
Fix config
5af3091 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin added archetypes 4.x Version 4.x labels Sep 25, 2023
@tvallin tvallin self-assigned this Sep 25, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 25, 2023
barchetta
barchetta approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some code indentation issues with the generated projects. I have created an issue to track that: #7665

@barchetta barchetta merged commit a57bbca into helidon-io:main Sep 25, 2023
12 checks passed
@tvallin tvallin deleted the archetype-config branch September 26, 2023 07:22
@tvallin tvallin mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@tvallin tvallin

Labels
4.x Version 4.x archetypes OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvallin @barchetta