Update HttpRules API to not have varargs with generics #7687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
HttpService
interface to not be aSupplier<HttpService>
to remove ambiguityReplace
register(Supplier<? extends HttpService>... service)
withregister(HttpService... service)
Overload it with 5 variants to accept up to 5 suppliers of services (
@SafeVarags
is not usable on interfaces)Add
register(List<HttpService> services)
for more than 5 servicesReplace
register(String pathPattern, Supplier<? extends HttpService>... service)
withregister(String pathPattern, HttpService... service)
Overload it with 5 variants to accept up to 5 suppliers of services (
@SafeVarags
is not usable on interfaces)Add
register(String pathPattern, List<HttpService> services)
for more than 5 servicesFixes #7656
Documentation
The changes are mostly compile compatible.
It's incompatible if an application was using an array of suppliers explicitly or if it was using more than 5 suppliers.
I.e.