Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Native image update #7711

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Oct 3, 2023

Description

  • Java 21
  • latest version
  • replace artifact id
  • remove initialize-at-build-time in SE
  • reintroduced packaging tests for native image

Resolves #7683

Had to introduce a custom main class to modularized projects (e.g. to all MP archetypes), as the jar plugin requires a main class that is in the package of the module (it now adds the main class to manifest, and as an attribute of the module-info.java to make the modules runnable).

Merged changes for Kafka from @danielkec

Documentation

I have updated the documentation for MP to mention new requirements.

In addtion this may influence existing users of Helidon SE, as we used to have build time initialization for almost everything. Now we have aligned with GraalVM guidelines, and we do not do it for SE (except for classes where it is a requirements).

- Java 21
- latest version
- replace artifact id
- remove initialize-at-build-time in SE
@tomas-langer tomas-langer added graal dependencies Pull requests that update a dependency file native-image 4.x Version 4.x labels Oct 3, 2023
@tomas-langer tomas-langer added this to the 4.0.0 milestone Oct 3, 2023
@tomas-langer tomas-langer self-assigned this Oct 3, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 3, 2023
applications/se/pom.xml Outdated Show resolved Hide resolved
docs/mp/aot.adoc Outdated Show resolved Hide resolved
examples/quickstarts/helidon-quickstart-se/pom.xml Outdated Show resolved Hide resolved
@danielkec
Copy link
Contributor

Checked Kafka connector and few more changes are needed tomas-langer/pull/4

tvallin
tvallin previously approved these changes Oct 4, 2023
Copy link
Member

@tvallin tvallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that a Main.java class is generated for both SE and MP, it makes sense to have a Main.java.mustache under archetype/common. But this change can be made in another PR. See #7714

@tomas-langer tomas-langer merged commit fc1a8bd into helidon-io:main Oct 4, 2023
12 checks passed
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
* Native image update
- Java 21
- latest version
- replace artifact id
- remove initialize-at-build-time in SE
- doc fix
- Updates to graalvm github action
- Upgrade jar plugin to honor main class attribute for modules
- Add main class to modularized test
- Add kotlin dependency to resolve modularized failure
- Native packaging test fixed.
- Fix archetypes to work with new jar plugin
- Kafka connector native image updates
---------

Co-authored-by: Daniel Kec <daniel.kec@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x dependencies Pull requests that update a dependency file graal native-image OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants