Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Adjusts paths to native-image.properties files in two projects to conform to the native-maven-plugin requirements as reported by the plugin #7746

Merged
merged 2 commits into from
Oct 7, 2023
Merged

[4.x] Adjusts paths to native-image.properties files in two projects to conform to the native-maven-plugin requirements as reported by the plugin #7746

merged 2 commits into from
Oct 7, 2023

Conversation

ljnelson
Copy link
Member

@ljnelson ljnelson commented Oct 6, 2023

I built an archetype and then tried to build a native image out of it.

During the native image build, I saw:

[WARNING] Properties file at 'jar:file:///Users/lairdnelson/.m2/repository/io/helidon/microprofile/server/helidon-microprofile-server/4.0.0-SNAPSHOT/helidon-microprofile-server-4.0.0-SNAPSHOT.jar!/META-INF/native-image/io.helidon.microrpofile/helidon-microprofile-server/native-image.properties' does not match the recommended 'META-INF/native-image/io.helidon.microprofile.server/helidon-microprofile-server/native-image.properties' layout.
[WARNING] Properties file at 'jar:file:///Users/lairdnelson/.m2/repository/io/helidon/microprofile/metrics/helidon-microprofile-metrics/4.0.0-SNAPSHOT/helidon-microprofile-metrics-4.0.0-SNAPSHOT.jar!/META-INF/native-image/io.helidon/helidon-common/native-image.properties' does not match the recommended 'META-INF/native-image/io.helidon.microprofile.metrics/helidon-microprofile-metrics/native-image.properties' layout.

This PR renames paths appropriately to conform to the expected layouts as reported by the GraalVM-authored native-maven-plugin.

@ljnelson
Adjusts paths to native-image.properties files in two projects to con…
affaff2 
…form to the native-maven-plugin requirements as reported by the plugin

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson added native-image 4.x Version 4.x labels Oct 6, 2023
@ljnelson ljnelson self-assigned this Oct 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 6, 2023
@ljnelson
Squashable commit; adds typo to pom.xml typo checker
5044aff 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson merged commit d4b6f96 into helidon-io:main Oct 7, 2023
12 checks passed
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
@ljnelson @dalexandrov
[4.x] Adjusts paths to native-image.properties files in two projects …
8e23ee1 
…to conform to the native-maven-plugin requirements as reported by the plugin (helidon-io#7746)

Adjusts paths to native-image.properties files in two projects to conform to the native-maven-plugin requirements as reported by the plugin

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@ljnelson ljnelson

Labels
4.x Version 4.x native-image OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljnelson @romain-grecourt