Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x][Doc] Config documentation update #7814

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Oct 17, 2023

Description

Helidon SE and MP doc update.

Fixes #6445

Documentation

This is mainly removal of no longer valid APIs from 2.x refactoring and making them up to date.

Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent requested a review from ljamen October 17, 2023 08:19
@Verdent Verdent self-assigned this Oct 17, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 17, 2023
@Verdent Verdent linked an issue Oct 17, 2023 that may be closed by this pull request
8 tasks
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small edits, looks great.

docs/se/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
docs/se/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
docs/se/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
docs/se/guides/config.adoc Outdated Show resolved Hide resolved
docs/se/guides/config.adoc Outdated Show resolved Hide resolved
Signed-off-by: David Kral <david.k.kral@oracle.com>
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes addressed, LGTM

@Verdent Verdent merged commit bdd42eb into helidon-io:main Oct 18, 2023
12 checks passed
@Verdent Verdent deleted the 6445-config-docs branch October 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: 4.x Config
2 participants