Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP Metrics Guide #961

Merged
merged 19 commits into from
Sep 10, 2019
Merged

MP Metrics Guide #961

merged 19 commits into from
Sep 10, 2019

Conversation

pfmackin
Copy link
Contributor

This is the MP Metrics Guide. It has several examples that demonstrate how to use Helidon metrics for an MP based application.

@spericas spericas requested a review from ljamen August 27, 2019 14:29
@spericas
Copy link
Member

@pfmackin Very nice guide!

Copy link
Contributor

@markxnelson markxnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stopping at 540 to discuss with paul how to get the code to work..

docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/09_metrics_mp_guide.adoc Outdated Show resolved Hide resolved
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @spericas or @tjquinno to confirm if this guide is valid for both MicroProfile 2.2 (Metrics 1.x) and MicroProfile 3.0 (Metrics 2.x). By the time this guide is published we'll be defaulting to MicroProfile 3.0 in the quickstarts.

It would be ideal if the guide worked for both Metrics 1.0 and 2.0. I dunno if that is practical.

barchetta
barchetta previously approved these changes Sep 9, 2019
barchetta
barchetta previously approved these changes Sep 9, 2019
@barchetta barchetta merged commit 613a010 into helidon-io:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants