-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP00xx: Safe RF Meta-Data Side Channel #249
HIP00xx: Safe RF Meta-Data Side Channel #249
Conversation
Acknowledged and looks great based on my initial review. I'm out most of day but will number and merge ASAP |
@wavesoft interesting proposal. Some thoughts (none of them critical, but might be useful)
|
Hello @mfalkvidd !
You are correct. The hotspot owners are the main stakeholders here. I will check how I can emphasize this on the document 👍
I am expecting this to be taken care partially by the hotspot manufacturers and through a helium mailing list notification. I don't think it makes much sense to add this anywhere on the UI because it might be unwanted noise for non-stakeholders. You raise however an interesting point : if a network operator/controller wants to enforce this as a policy down to all hotspots that (s)he owns, how would this work? Personally I have a feeling that answering this in this HIP might over-bloat it's scope, but that's an interesting discussion to have on another HIP. What do you think?
That's actually a quite elegant solution. I like it, but there is an unfortunate side-effect: this requires that the hotspot client should maintain a queue of the messages and replay them with a given delay. If too many messages arrive at close intervals, then you are increasing the memory pressure, risking to loose messages, or to ran out of memory in compact hardware solutions.
I absolutely agree on that, that's why I also mentioned that some discussion is needed to settle on the actual format. I am still undecided on weather it should be encoded with ProtoBuf, or with a Semtech UDP style JSON (for this compatibility). You will also notice that I have kept almost all of the fields from the UDP protocol (even the |
I'm having some pushing-to-remote-fork pains with gh so I'm goign to squash-merge here and then number the HIP in |
This HIP draft has been reviewed, numbered, and merged for discussion! Please direct future feedback & questions to its central tracking issue: #250 |
Author(s): @wavesoft, @dmamalis
Initial PR: #249
Start Date: 2021-07-28
Category: Technical
Rendered view:
https://github.com/helium/HIP/blob/9ce376f2d18d973fb26aac44360f072cb6d86512/00xx-safe-rf-metadata-side-channel.md
Summary:
The goals of these changes are to: