This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madninja
reviewed
Apr 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 71.53% 71.48% -0.06%
==========================================
Files 97 97
Lines 14009 14042 +33
==========================================
+ Hits 10022 10038 +16
- Misses 3987 4004 +17
Continue to review full report at Codecov.
|
evanmcc
approved these changes
Apr 9, 2021
vihu
force-pushed
the
rg/payment-v2-memos
branch
from
April 19, 2021 18:19
bd9270c
to
5eddaad
Compare
- Update to_json for payment-v2 - Update error msg for old behavior
- Dont allow memo greater than a 64 bit integer - Add test cases for big memo validation
vihu
force-pushed
the
rg/payment-v2-memos
branch
from
April 20, 2021 20:14
5eddaad
to
a3b7118
Compare
Did we want to land this? |
I think this is good to land despite differing slightly from HIP26, but the author seems okay with this implementation as well. |
Vagabond
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables support for specifying a uint64 memo for a payment-v2.
Notes:
allow_payment_v2_memos
boolean chain variableTODO: