Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift language support #1964

Closed
diktomat opened this issue Apr 5, 2022 · 6 comments
Closed

Add Swift language support #1964

diktomat opened this issue Apr 5, 2022 · 6 comments
Labels
C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed

Comments

@diktomat
Copy link
Contributor

diktomat commented Apr 5, 2022

No description provided.

@diktomat diktomat added the C-enhancement Category: Improvements label Apr 5, 2022
@archseer archseer added E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Extra attention is needed E-good-first-issue Call for participation: Issues suitable for new contributors labels Apr 5, 2022
@archseer
Copy link
Member

archseer commented Apr 5, 2022

Grammar is https://github.com/alex-pinkus/tree-sitter-swift, someone just needs to go over and fix up the highlighting queries

@diktomat
Copy link
Contributor Author

diktomat commented Apr 5, 2022

Looked at that for doing this myself, problem is they don't include the parser.c etc. in the repository and instead advise using the crate or npm package, which helix doesn't support.

Also, LSP is included in Xcode via xcrun sourcekit-lsp or the Xcode-independent Swift toolchain from swift.org.

@archseer
Copy link
Member

archseer commented Apr 5, 2022

Hmm: https://github.com/alex-pinkus/tree-sitter-swift#where-is-your-parserc

If we supported http sources rather than git you could fetch it from the latest github actions build

@the-mikedavis
Copy link
Member

Currently the work-around that we have for this is to fork the repository and check in the generated C files (for example: https://github.com/jaredramirez/tree-sitter-rescript). I have a more long-term plan that will fix this but it isn't quite ready yet.

@diktomat
Copy link
Contributor Author

diktomat commented Apr 5, 2022

Currently the work-around that we have for this is to fork the repository and check in the generated C files

Have to admit I don't really want to do that, I'd 100 % forget/procrastinate updating that, letting it get out of date … Maybe I'll find time to automate updating the fork, then of course I can contribute support for Helix myself.

Meanwhile, I created an issue there to include the files …

@the-mikedavis
Copy link
Member

Closed by #2033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants