-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme keys for the picker header area #11343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the ui.picker.header
key will change the meaning for it that I had in mind when introducing it. The current behavior is that the bg
or modifiers (underlined for example) will only affect the column names. For example in my theme I have "ui.picker.header" = { underline.style = "line" }
:
But if we apply the style to the header area:
I could see both ways being useful so I think we should change the keys around so that both are possible. Let's use ui.picker.header
for the header (Row
)'s style and introduce ui.picker.header.column
that replaces the current use of ui.picker.header
. Then ui.picker.header.active
can move to ui.picker.header.column.active
We usually try to avoid breaking changes but these theme keys were merged very recently and no themes are using it in the runtime/themes
dir yet so I think it's fine in this case.
4422d43
to
9d1c5e0
Compare
@the-mikedavis I have resolve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good codewise. We just need to update the docs about these keys too:
Lines 300 to 301 in 6eae846
| `ui.picker.header` | Column names in pickers with multiple columns | | |
| `ui.picker.header.active` | The column name in pickers with multiple columns where the cursor is entering into. | |
9d1c5e0
to
2134b8a
Compare
@the-mikedavis yes ,the document has been supplemented. |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* feat: pertty header * 更新 themes.md Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* feat: pertty header * 更新 themes.md Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* feat: pertty header * 更新 themes.md Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* feat: pertty header * 更新 themes.md Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
full fill column's background for picker, it can be defined use