-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make it possible to keybind TypableCommands
#1169
Conversation
113cb85
to
c8862c2
Compare
5f73c6a
to
856443e
Compare
856443e
to
2c65440
Compare
Rebased updated |
Yeah, I've been wanting to do this for a while but it will break pending PRs in the queue. Let's wait until I manage to catch up with the merges. |
@archseer Sure, like I said I don't want to do that in this pr since that would make it quite huge. Better to do it in a separate pr imo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd like to get an approval from @sudormrfbin too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Great work @Nehliin 🎉
Fixes: #852
This makes it possible to add keymaps for
TypableCommands
(including aliases + commands with arguments) in yourconfig.toml
like the following example:This solution is a lot less hacky than my previous pr and makes it possible to map all current and future
TypableCommands
. I decided to not go for the[ .. ]
surround for command arguments because it would just be more of a hassle to parse with little benefit for users imo. Arguments are passed by space separating them after the initial command instead.Update: aliases are supported as well so updated the example