Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rust proc macro support #1350

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

lnicola
Copy link
Contributor

@lnicola lnicola commented Dec 24, 2021

loadOutDirsFromCheck is now called runBuildScripts and has been enabled by default for 10 months. And proc macros are enabled in upstream by default, so maybe there's no particular reason to disable them?

2021-12-24.11-55-57.mp4

@archseer
Copy link
Member

@luctius added these in #460, I assumed it's to avoid arbitrary code execution (an exploited crate could contain a malicious proc_macro).

Might be better to match upstream defaults though.

@lnicola
Copy link
Contributor Author

lnicola commented Dec 24, 2021

I considered that, but executing build scripts and running cargo check on save already bring the same risks and they are enabled at the moment.

@archseer
Copy link
Member

Agreed 👍

@archseer archseer merged commit 13d8044 into helix-editor:master Dec 24, 2021
@lnicola lnicola deleted the rust-proc-macros branch December 24, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants