improve markdown's ui theme #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Dec 29, 2021
| @@ -5234,7 +5234,8 @@ fn hover(cx: &mut Context) { | |||
|
|
|||
| // skip if contents empty | |||
|
|
|||
| let contents = ui::Markdown::new(contents, editor.syn_loader.clone()); | |||
| let contents = | |||
| ui::Markdown::new(contents, editor.syn_loader.clone()).style_group("hover"); | |||
There was a problem hiding this comment.
Change looks good, but do we need these extra scopes? We can simplify and remove hover/completion suffix
There was a problem hiding this comment.
markup.raw.inline， markup.heading not only used in editor veiw but also used in popup ui. The two ui has own background. Some theme maybe conflict on these.
archseer
requested changes
Jan 6, 2022
cossonleo
force-pushed
the
markdown_theme
branch
from
351657c to
ed73fa3
Compare
archseer
approved these changes
Jan 11, 2022
|
Going to merge after #1525 adds all the |
|
Can you rebase the PR? I did so locally but I can't push to your fork |
cossonleo
force-pushed
the
markdown_theme
branch
from
ed73fa3 to
52bdac5
Compare
Has rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add some style to markdwon ui to make the theme can be changed.
before:
after:
