added tab to insert mode

[janhrastnik]

Cursor isn't rendering properly when using tabs and I'm not sure why. Should move for 4 characters to the right but only moves for 1.

[archseer]

You can simplify this:

pub fn screen_coords_at_pos(text: &RopeSlice, pos: usize) -> Coords {
  let line = text.char_to_line(pos);
  let line_start = text.line_to_char(line);
  let line_slice = text.slice(line_start..pos);

  let mut x = 0;
  ...
`

[archseer]

That said, this returns (screen_x, line_number). What we want is (screen_y, screen_x) so representing (row, col). You should move this to editor.rs screen_coords_at_pos(view: &View, text: &RopeSlice, pos: usize) -> Coords and use view.first_line & last_line on screen to calculate the row.

Add a function called last_line to View

/// Calculates the last visible line on screen
pub fn last_line(&self, viewport: Rect) -> usize {
  std::cmp::min(
      (self.first_line + viewport.height - 1) as usize,
       self.state.doc().len_lines() - 1,
  );
}

Put this in the editor.rs file

/// Translates a document position to an absolute position in the terminal. 
pub fn screen_coords_at_pos(view: &View, text: &RopeSlice, pos: usize) -> Option<Position> {
  let line = text.char_to_line(pos);
  
  if line < self.first_line || line > self.last_line() {
    // Line is not visible on screen
    return None;
  }

  let line_start = text.line_to_char(line);
  let line_slice = text.slice(line_start..pos);

  let mut col = 0;
  
   ... for loop etc

  let row = line - view.first_line;

  Some(Position::new(row, col))
}

Then you can also replace

helix/helix-term/src/editor.rs

Lines 88 to 91 in 7b4a4f6

	let last_line = std::cmp::min(
	(view.first_line + viewport.height - 1) as usize,
	view.state.doc().len_lines() - 1,
	);

with a call to last_line()