-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend tutor file #2133
Extend tutor file #2133
Conversation
- Changing selections to uppercase / lowercase - yanking and pasting - macros - selecting to chars with t and f PS: I got kind of carried away and put off commiting for a while, will commit to commit more often in the future.
The gaps separating the sections were intentional; they were such that there is an even amount of space between each section header (regardless of how much content is in the section) so that in an 80x24 terminal, page-up and page-down will smoothly switch between sections, keeping headers right at the top of the screen. |
Thanks for all the feedback. I'll work on this soon as I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing capitalization:
- "Selecting to a Character" steps 2–4 and "Helix" and "Vim" in the note
- "Selecting 'til a Character" steps 2–3 and "Helix" and "Vim" in the note
- First "Recap" of the PR bullet 5
- "Copying and Pasting Text" steps 2–3 and "Helix" in the first note
- "Setting Case" steps 2–3
- Second "Recap" of the PR bullet 4
- "Joining Lines" steps 2–3
- "Indenting Lines" step 2
Missing periods:
- "Selecting to a Character" step 3
- "Selecting 'til a Character" introductory text and step 4
- First "Recap" of the PR bullet 3
- "Copying and Pasting Text" step 4 and second note
- "Switching Case" step 2
- "Setting Case" step 3
- "Macros" step 4
- Second "Recap" of the PR all bullets
- "Indenting Lines" introductory text
- Third "Recap" of the PR bullet 3
This is so that - on a 24 line terminal - only one section is visible at a time and page up/page down goes straight to the next section keeping the header at the top.
Alright I have largely resolved this but the section "copying and pasting text" is too big to fit on the screen. I'm thinking removing the "Note:" part of the footnotes or splitting this into two sections: 1 for yanking and 1 for pasting, what would you suggest? Edit: By the "Note:" part, I just mean the word "Note:", note the whole thing. Just trimming off extra words to squeeze it to fit. |
Co-authored-by: Omnikar <omkar.subramaniam@icloud.com>
Co-authored-by: Omnikar <omkar.subramaniam@icloud.com>
Co-authored-by: Omnikar <omkar.subramaniam@icloud.com>
Co-authored-by: Omnikar <omkar.subramaniam@icloud.com>
Co-authored-by: Omnikar <omkar.subramaniam@icloud.com>
Co-authored-by: Omnikar <omkar.subramaniam@icloud.com>
I am having a not very good time with git. I can't git push the branch because it's "behind it's remote counterpart". I have git pulled from my fork but it's apparently up to date. I'm really sorry, I'm still new to using git/github so if you have any help that'd be very appreciated. |
The solution to that should be |
Hm, separating yanking and pasting into different sections doesn't make sense; I'll have to think about what to do. |
git stash says |
Are you looking at the correct branch on your local computer? |
- "Press" for single keypresses - "Type" for multiple keypresses / modifiers - "Use" when referencing two inputs as a pair.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks a lot better to me but still left some comments for minor changes.
I think there has to be a clear convention on when to say "press" and when to say "type". Seems a bit petty but there can be clear inconsistencies without one and saying just one for everything doesn't make sense.
I've mentioned that saying "use" in all cases would be an easy solution and more consistent but it's a little strained and "press"/"type" usually seems more natural. |
cc @Omnikar what do you think? Should we just use the same "press" for everything so to not assume which layout the user is on? For example for dvorak for programmer (dvp) pressing |
I think the best solution is to always use "type" honestly. |
Ok, let's just go with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think this should be good now, since this is tutor file and no other maintainers is reviewing this so I guess I will merge this for now.
Here are the sections I've added:
Also now adds section numbers (1.1, 1.2 etc. ).
I'm not 100% on the order of the sections, e.g maybe yanking and pasting should come earlier, but I've left the previous part of the file mostly untouched.