Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change A-left right to C-left right in insert #2193

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Apr 20, 2022

Currently A-left move one word left and the behavior will be more
consistent for people coming GUI world if the key was changed to control
given that both browsers and editors like vscode uses C-left right by
default to move word rather than alt.

I wanted to change A-backspace to C-backspace as well but I don't seemed to be able to do that. I saw this when looking at #2131

cc @QiBaobin since he did the initial version but not sure why he did it that way, maybe consistency with alt-backspace?

Currently A-left move one word left and the behavior will be more
consistent for people coming GUI world if the key was changed to control
given that both browsers and editors like vscode uses C-left right by
default to move word rather than alt.
@EpocSquadron
Copy link
Contributor

I wanted to change A-backspace to C-backspace as well but I don't seemed to be able to do that. I saw this when looking at #2131

Ctrl-backspace is an ambiguous escape in most terminals, unless you have CSIu support in the terminal emulator.

@pickfire
Copy link
Contributor Author

Let's wait for a reviewer with write access to approve.

@archseer archseer merged commit c22873c into helix-editor:master Apr 29, 2022
@pickfire pickfire deleted the insert-c-word branch May 8, 2022 23:28
CBenoit added a commit to CBenoit/helix that referenced this pull request Jul 6, 2022
Ctrl-based shortcuts are common in numerous applications.

This change:
- Adds Ctrl+{Left/Right/Backspace/Delete} for word-wise movement/deletion in prompt, picker, …
- Removes Alt-Left and Alt-Right in prompt, picker, …
- Adds Alt-Delete in insert mode for forward word deletion

In some terminals, Alt-Backspace might not work because it is ambigous.
See: helix-editor#2193 (comment)
Hence, Alt alternative is not removed.
CBenoit added a commit to CBenoit/helix that referenced this pull request Jul 6, 2022
Ctrl-based shortcuts are common in numerous applications.

This change:
- Adds Ctrl+{Left/Right/Backspace/Delete} for word-wise movement/deletion in prompt, picker, …
- Removes Alt-Left and Alt-Right in prompt, picker, …
- Adds Alt-Delete in insert mode for forward word deletion

In some terminals, Alt-Backspace might not work because it is ambigous.
See: helix-editor#2193 (comment)
Hence, Alt alternative is not removed.
CBenoit added a commit to CBenoit/helix that referenced this pull request Jul 6, 2022
Ctrl-based shortcuts are common in numerous applications.

This change:
- Adds Ctrl+{Left/Right/Backspace/Delete} for word-wise movement/deletion in prompt, picker, …
- Removes Alt-Left and Alt-Right in prompt, picker, …
- Adds Alt-Delete in insert mode for forward word deletion

In some terminals, Alt-Backspace might not work because it is ambigous.
See: helix-editor#2193 (comment)
Hence, Alt alternative is not removed.
pickfire pushed a commit that referenced this pull request Jul 15, 2022
Ctrl-based shortcuts are common in numerous applications.

This change:
- Adds Ctrl+{Left/Right/Backspace/Delete} for word-wise movement/deletion in prompt, picker, …
- Removes Alt-Left and Alt-Right in prompt, picker, …
- Adds Alt-Delete in insert mode for forward word deletion

In some terminals, Alt-Backspace might not work because it is ambigous.
See: #2193 (comment)
Hence, Alt alternative is not removed.
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
…2500)

Ctrl-based shortcuts are common in numerous applications.

This change:
- Adds Ctrl+{Left/Right/Backspace/Delete} for word-wise movement/deletion in prompt, picker, …
- Removes Alt-Left and Alt-Right in prompt, picker, …
- Adds Alt-Delete in insert mode for forward word deletion

In some terminals, Alt-Backspace might not work because it is ambigous.
See: helix-editor#2193 (comment)
Hence, Alt alternative is not removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants