feat: show filetype and filetype icon and lsp name in statusline

[ttys3]

I'd like to show filetype and filetype icon and lsp name in statusline

is there better way to do this?

maybe more flexiable way, using a language like starlark ?

currently the code is rather tricky and dirty and not ready for merge, and just for discussion.

ft_icons.toml is auto generated via a lua script (lua gen.lua > ft_icons.toml) which mainly get the icons via https://github.com/kyazdani42/nvim-web-devicons/blob/master/lua/nvim-web-devicons.lua

gen.lua

#!/usr/bin/env lua

local icons = require "nvim-web-devicons"

for key, value in pairs(icons.get_icons()) do
    print(string.format('"%s"="%s"', key, value.icon))
end

here's the demo:

[David-Else]

What about if there are multiple LSPs active (in possible future updates)?

[ttys3]

What about if there are multiple LSPs active (in possible future updates)?

yes, multiple LSPs currrently not supported, but I think it could be supported with minor updates.

future updates currently not supported. actully I did not take much time to investigate the code about how the statusline is rendered and updated.

[CptPotato]

Is the statusline currently configurable? I think using the langauge icons might cause issues for people who don't use fonts that include them.

[ttys3]

yes, unicode emoji will be a problem for user who don't have an emoji font.

so I think it is better if the statusline is configurable.

a simple config will be a boolean item, which allow user to enable this feature. but this config maybe not flexiable

but I think maybe we can use something like starlark, so the user can define his own func to return the icon

[EpocSquadron]

Beyond devicons there is also nerd fonts , which is a superset. I think it's relatively common to have support for it via a toggle. I think it would be a good approach here to include the info on the status line and check a global toggle for nerd fonts. Then we can show icons not just here but in various other places as well.

[David-Else]

I never got nerd fonts to work, I really don't like them! I instead use:

https://github.com/microsoft/vscode-codicons
https://microsoft.github.io/vscode-codicons/dist/codicon.html

and they work out great, no need to patch anything. They look like this in Neovim:

[the-mikedavis]

I would prefer to only show the language name/scope - the icons seem unnecessary to me and that they need a patched font doesn't help. Plus https://github.com/kyazdani42/nvim-web-devicons is not licensed so I don't know where it stands on distributing the ft_icons.toml.

[ttys3]

as for the license issue, I do not think this could be a problem. we could create ft_icons.toml by our own, which we only use unicode emoji, which is absolutely has no license issue. and also, we may allow user to override ft_icons.toml by their own.
(yes, just like languages.toml override)

yes, need a patched font, this is something not perfect, but for most users, this should not be a big problem.

[archseer]

Requiring patched or custom fonts to properly display in an editor is an automatic ❌ for something built in or available out of the box.

Similar to #649 (comment) I'd like to see this be a part of statusline config so users can add it in if they want but it's off by default since a language name + icon are redundant most of the time. It's going to be hard to add this with just the toml config though.

[CptPotato]

fwiw, I really like the icons, but I agree that it should be opt-in.

[the-mikedavis]

Should we close this in favor of #2434?

[ttys3]

@the-mikedavis I'll close this PR now.

but I still do not like the implementation of static config fields like #2434

I think if we could use some script, like lua or starlark to config the statusline.

the idea is expose statusline related api to the script lang, and then let the script to config and build the final statusline.

in that way, user can have their own filetype emoji or do anything we can not do now, as it does not depend on the helix Rust code anymore.