Fix nondeterministic highlighting #3275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2986.
Resolves #3230.
Probably resolves #2484 as well, although I didn't have the code to copy paste in order to check :P
This is done by preferring matches in the beginning, i.e. for
keyword.function
,keyword
is a better match thanfunction
.Explanation of original problem:
Source for non-determinism:
HashMap
traverse order is different each time.According to comments:
keyword.function
can therefore match bothkeyword
andfunction
.match_len
which is what is used to rank themmatch_len
, in therandom order it came from the HashMap.