Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate 'brace action' and 'match selection' in keymap #3893

Closed
wants to merge 1 commit into from
Closed

Separate 'brace action' and 'match selection' in keymap #3893

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2022

This changes the behavior of m to only match selections.
m = mi
M = ma
Brace actions are relocated to ^.

Issue: #3852

This changes the behavior of `m` to only match selections.
Brace actions are relocated to `^`.
@the-mikedavis
Copy link
Member

I like the idea of easier access to mi/ma.

I don't like relocating brace actions to ^ though. ^ has been proposed and tried for a few Kakoune keymaps (marks, mawww/kakoune#1116) but it has never stuck. It's not very discoverable. (Plus I'd like to use it for marks/selections #3720 :P)

The normal-mode keymap is already very full which is why it's hard to separate key sequences like m out like this.

@the-mikedavis the-mikedavis added A-keymap Area: Keymap and keybindings S-needs-discussion Status: Needs discussion or design. labels Sep 18, 2022
@ghost
Copy link
Author

ghost commented Sep 19, 2022

I like the idea of ^ being reserved for marks also.

I do think brace functionality deserves it's own key rather than being nested under another diag.

@dead10ck
Copy link
Member

I am also not a fan of ^. This also breaks the "in" / "around" mnemonic. I don't think this is worth saving a single keystroke.

@ghost ghost closed this by deleting the head repository Nov 8, 2022
@ghost ghost reopened this Nov 8, 2022
@ghost ghost closed this Nov 8, 2022
@ghost
Copy link
Author

ghost commented Nov 8, 2022

moved to #4655

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keymap Area: Keymap and keybindings S-needs-discussion Status: Needs discussion or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants