Add rainbow indentation guides #4493
Conversation
kirawi
added
A-gui
|
Anyone up for reviewing? I and, I bet many others would greatly appreciate it! Thanks in-case someone does! |
This review kinda depends on the rainbow bracket PR, as i am using the same mechanism to get rainbow colours. |
Ah thanks for clarifying! |
|
Just linking the PR to the rainbow brackets here as a sort of dependency tracker: |
sudormrfbin
added
the
S-waiting-on-pr
This change adds a field to the schema of themes which takes a
list of styles.
rainbow = ["red", "orange", "yellow", { modifiers = ["reversed"] }]
[palette]
red = "#ff0000"
orange = "#ffa500"
yellow = "#fff000"
Normal style rules apply for each element in `rainbows`: you can
use definitions from the palette and the full fg/bg/modifiers
notation.
Themes written with `rainbow` keys are not backwards compatible.
Parsing errors will be generated for older versions of Helix
attempting to use themes with `rainbow` keys.
A default rainbow is provided with base16 colors.
This change is made with rainbow pair characters (parens, brackets, etc.)
in mind but it could also be used for other rainbow cosmetic elements
like rainbow indent-guides.
SoraTenshi
force-pushed
the
colored-indent-guides
branch
2 times, most recently
from
44a57c6 to
ea58a7a
Compare
Docs fmt
SoraTenshi
force-pushed
the
colored-indent-guides
branch
from
ea58a7a to
d1517c6
Compare
|
Closes #4010 (for tracking purposes) |
|
Just asking, but can this option can be used for highlighting the active indent guide and dimming the others? Like this:
|
That's not part of this PR. |
|
I see, if so I think that #4010 should not be closed. The issue specifically mentions:
|
ref: helix-editor/helix#4010 ref: helix-editor/helix#4493 Co-authored-by: SoraTenshi <dream@neoncity.dev>
Since the last PR is kind of broken, check PR #4056 for more info.