-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add switch case by kind functions #4615
Conversation
LGTM, although you need to run |
thank you for your reply. this is just a set of |
@@ -67,6 +67,9 @@ serde = { version = "1.0", features = ["derive"] } | |||
grep-regex = "0.1.10" | |||
grep-searcher = "0.1.10" | |||
|
|||
# case conversion | |||
heck = "0.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulls in another dependency :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heck
has only one dependency : unicode-segmentation = { version = "1.2.0", optional = true }
and did not use by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but heck is a new dependency that's pulled in for just a couple commands.
I don't think it's necessary to add commands for this. Converting case is possible to do with just regular editing primitives. The Kakoune introduction docs even use it to show off the power of selections and multiple cursors: https://kakoune.org/why-kakoune/why-kakoune.html#_multiple_selections |
@the-mikedavis consider any conversion between the following 7 cases,
if regular editing primitives is used, it is not easy to do. |
If we added macro keybinds then this would be easier to map to a key. A simpler implementation that doesn't pull in heck could also just set the macro register to a sequence of these keys, then execute the macro |
ok, thanks for your replies |
I made my own solution after not finding anything satisfactory... Probably also helpful for #5197 Source is here: https://github.com/peterwilli/ToCase |
No description provided.