Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ANSI colors in themes #5119

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Allow ANSI colors in themes #5119

merged 1 commit into from
Jun 19, 2023

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Dec 11, 2022

My current vim theme doesn't use rgb colors but instead uses the ANSI color (150, 174, etc).

Is this something Helix want to be able to do? It seems it already supports some colors (black, etc) but not all the ANSI colors.

@tomleb
Copy link
Contributor Author

tomleb commented Dec 11, 2022

Figured how to install rustfmt and run cargo fmt --all --check. Fixed the lint CI error.

@pascalkuthe pascalkuthe added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 11, 2022
@the-mikedavis
Copy link
Member

I think it makes sense to add this so that themes can work well with 256-color terminal themes. What do you think @archseer?

A note on ANSI-colors should be added to the book somewhere in the color palettes section

### Color palettes

@tomleb
Copy link
Contributor Author

tomleb commented Dec 22, 2022

A note on ANSI-colors should be added to the book somewhere in the color palettes section

I added a note on this in a new Colors section. I'm not sure about the wording, and I'm not making a distinction between regular colors and colors palettes colors.. Maybe someone has better wording for this?

I haven't found yet how to build the book, haven't had much time to search that though.

@bresilla
Copy link

Is there any timeline when this will be merged? I am just writing here cos I don't want this to be forgotten :)

It's only few lines of code change, and makes possible to use all ANSI (255) colors.

@archseer archseer merged commit 29638ba into helix-editor:master Jun 19, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants