Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale language support for tutor #5199

Closed
wants to merge 1 commit into from
Closed

Add locale language support for tutor #5199

wants to merge 1 commit into from

Conversation

erasin
Copy link
Contributor

@erasin erasin commented Dec 18, 2022

  • Added Chinese Simplified tutor file

@kirawi kirawi added A-documentation Area: Documentation improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 20, 2022
Jiuh-star
Jiuh-star reviewed Dec 23, 2022
View reviewed changes
runtime/tutors/zh_cn.txt Outdated

键入 o 会在光标所在位置的下方新建一行，并进入插入模式。
键入 u 可以进行撤销操作。
键入 U 可以
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation, but remain some mistakes. In 2.2 新建行 (2.2 OPENING LINES) :

 键入 u 可以进行撤销操作。
 键入 U 可以

should not be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I will check again.

@erasin erasin force-pushed the tutor-locale branch 2 times, most recently from 2f60274 to d9d5b2f Compare December 23, 2022 10:51
@Omnikar
Copy link
Contributor

Omnikar commented Dec 26, 2022

The .txt extension that used to be on the original tutor file was removed because the fact that the path is unset after it is opened was causing problems for people who had a language server set up for .txt files. I would as such suggest removing the .txt extension here too.

@erasin erasin force-pushed the tutor-locale branch 3 times, most recently from 1a336bd to dc89837 Compare December 28, 2022 01:41
@erasin
Add locale language support for tutor
aebfd5e 
- Added Chinese Simplified tutor file
@gibbz00 gibbz00 mentioned this pull request Feb 22, 2023
Closed
5 tasks
@pascalkuthe
Copy link
Member

I don't want to be resonsible for maintaing stuff in languages I can't read. This will quickly fall out of sync as the main file changes and maintainers and contributors won't be able to update. This can be maintained out of tree since the tutor is just a simple.

I will close this as this is alerayd ouut of date with the tutor changes of the last year and I don't see us moving forward with this

@pascalkuthe pascalkuthe closed this Apr 8, 2024
@erasin erasin deleted the tutor-locale branch April 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiuh-star Jiuh-star Jiuh-star left review comments

Assignees
No one assigned
Labels
A-documentation Area: Documentation improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erasin @Omnikar @pascalkuthe @Jiuh-star @kirawi