Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub themes #5353

Merged
merged 3 commits into from
Jan 7, 2023
Merged

Add GitHub themes #5353

merged 3 commits into from
Jan 7, 2023

Conversation

alven-shin
Copy link
Contributor

A GitHub color theme based on the VSCode GitHub theme. The variants are based on the Primer Primitive Colors. Templates were created for the Light and Dark variants to closely match the VSCode ones. The others were generated based on the two templates.
Screen Shot 2022-12-31 at 5 33 15 PM
Screen Shot 2022-12-31 at 5 31 57 PM

@kirawi kirawi added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 1, 2023
@archseer
Copy link
Member

archseer commented Jan 1, 2023

Are just the palettes different? If so you could use inherits to only override the palette, and declare the scopes once

@archseer
Copy link
Member

archseer commented Jan 1, 2023

Great work on this by the way! I really wanted these themes included :)

@alven-shin
Copy link
Contributor Author

alven-shin commented Jan 1, 2023 •
edited
Loading

Are just the palettes different? If so you could use inherits to only override the palette, and declare the scopes once

Oh right, theme inheritance was just added. I am not sure if the built-in themes should be using the inherit feature or not though.

@pascalkuthe
Copy link
Member

Are just the palettes different? If so you could use inherits to only override the palette, and declare the scopes once

Oh right, theme inheritance was just added. I am not sure if the built-in themes should be using the inherit feature or not though.

Other builtin themes (like tokio, autumn and hex) already do and it's usually preferable to duplication

archseer
archseer approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@archseer archseer merged commit 9f0d939 into helix-editor:master Jan 7, 2023
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
@alven-shin
Add GitHub themes (helix-editor#5353)
96fb081 
* Add github themes

* Increase contrast for hover and completion menus

* Use inheritance for the GitHub themes
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
@alven-shin
Add GitHub themes (helix-editor#5353)
8a5b6ae 
* Add github themes

* Increase contrast for hover and completion menus

* Use inheritance for the GitHub themes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alven-shin @archseer @pascalkuthe @kirawi