-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reset idle timeout when pushing a new compositor layer #5660
Conversation
15f4c01
to
a4adcf7
Compare
I see what you were saying in #5115 with the callsites all adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fixes also when just opening the file-picker with a low idle-timeout (same issue as #4956)
Is there anything blocking this? This seems relatively straight-forward. |
Well apart from the fact, being completely out of sync with master. I have decided against fixing merge/rebase conflicts and replay the changes (as it seemed simpler than fixing the conflicts) for my own fork. Here's a version that is has no merge conflicts with master: 97f310a |
I was waiting for a decision from @archseer whether he wants to go forward with this. If he approves of the general idea I would rebase. In the long term this is not really the the right fix since I mostly want to rebase the kitchensinky idle timeout with a more granular event system. So it may not be worth to merge this over that. |
Yeah absolutely agree with a finer-grained idle-timeout system, thought about that myself already. |
I already have a working event system locally (just haven't go around to finishing it) so its not too far away :) I would be ok with rebasing and merging this it depends on what @archseer thinks |
@pascalkuthe do we need this anymore now that we have #8021? |
Fixing this still needs some work to switch the picker away from the idle timeout but yeah let's close this. I don't think this is the right approach now thatwe have the Event system |
Fixes #4956
As suggested in #4956 (comment) the right fix is to
reset the idle timer when pushing new layers into the compositor.