Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use editor.shell for formatter #5832

Closed
wants to merge 1 commit into from

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Feb 5, 2023

Objective

Solution

  • Copied the way that the shell is used in helix_term::commands::shell_impl_async:
    let mut process = Command::new(&shell[0]);
    process
    .args(&shell[1..])
    .arg(cmd)
    .stdout(Stdio::piped())
    .stderr(Stdio::piped());

Changelog

now passes external formatters to editor.shell

@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 5, 2023
@archseer
Copy link
Member

We decided against this here #8064 (comment)

@archseer archseer closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand tilde to home-directory for language formatter command args
2 participants