-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust everforest to resemble original more closely #5866
Conversation
\cc @CptPotato what do you think? |
I'm fine with this change, didn't know the colors were changed at some point 👍 When I created the port I didn't follow the original theme super closely because I preferred this look. I'm a bit on the fence about which version I like better but for the "official" themes that are bundled with helix it makes sense to adhere more to the original, so I'd say go ahead. |
Thanks for the feedback. While the original vim theme has many small adjustments for different languages, I tried to stay with what is defined in the code for the general treesitter attributes (see everforest/everforest.vim at master · sainnhe/everforest) since those are also close to what helix uses. Some but not all of the code is mirrored / documented in https://github.com/sainnhe/everforest/blob/master/palette.md The vscode theme with the same name (same author!) seems to deviate a lot from the vim one. I made a new commit (see below) which I could further tweak or squash depending on your feedback.
I decided to stick with the original theme there at first which defines
Thanks, fixed that oversight
I see how this leaves a lot of room for debate. Fira Code particularly will be problematic in this case since it doesn't have italics natively (?) and needs special setup in the terminal to produce "proper" italics (like derived from another font). I don't know what your preferred solution is for italics:
|
Thanks for elaborating!
Sounds like a good compromise to me 👍
I'd say keep the italic modifiers and don't bother creating variants. I don't see this "issue" as a reason to remove them. To enable/disable italics it's probably a better idea to provide an editor config option, similar to global theme overrides that have been proposed.
There aren't any issues left that stick out to me, so I think this is good to go now. |
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Rebased and added styling of inlay-hints and soft-wrap indicator |
Adjust palettes and assignments:
Color palettes of upstream everforest where tweaked since creation of this port:
Move the helix everforest theme closer to the documented
upstream vim theme