Fix crash in goto_window_center at EOF #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
the-mikedavis
approved these changes
Feb 14, 2023
the-mikedavis
changed the title
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5965
Reverts a small change from #5892 that caused crashes at the EOF.
std::cmp::clampcrashes whenmax < minwhich was the case at the EOF.By using
max(..).min(..)directly we ensure that theminalways takes predence and avoid the crash.In the other place where
min/maxwas replaced withclampin #5892 it is impossible formax < minto occurand therefore didn't need to be reverted.