Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6669: Theme preview doesn't return theme to normal #6694

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fix #6669: Theme preview doesn't return theme to normal #6694

merged 2 commits into from
Apr 12, 2023

Conversation

h1t
Copy link
Contributor

@h1t h1t commented Apr 10, 2023

Theme preview doesn't return theme to normal when delete name with Alt-Backspace

@h1t h1t changed the title Fix #6669 Fix #6669: Theme preview doesn't return theme to normal Apr 10, 2023
the-mikedavis
the-mikedavis reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the same change on the next three lines? We want to also call the prompt callback for other keybinds that change the prompt text

@h1t
Fix helix-editor#6669: Return theme preview to normal theme for all r…
e9811d2 
…emaining keybinds that change the promt text
@h1t
Copy link
Contributor Author

h1t commented Apr 11, 2023

I added fix, but I can't fix another issue for kill_to_end_of_line and kill_to_start_of_line actions:

  1. :theme default
  2. Ctrl+u
  3. Esc

Result: theme preview is not return to normal theme.

@h1t h1t requested a review from the-mikedavis April 11, 2023 05:59
pickfire
pickfire approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We have have a look of the other issues separately.

@pickfire pickfire merged commit 9f680c6 into helix-editor:master Apr 12, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@h1t @Triton171
Fix helix-editor#6669: Theme preview doesn't return theme to normal (h…
87f54dd 
…elix-editor#6694)

* Fix helix-editor#6669: Theme preview doesn't return theme to normal when delete name with Alt-Backspace

* Fix helix-editor#6669: Return theme preview to normal theme for all remaining keybinds that change the promt text
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@h1t @wes-adams
Fix helix-editor#6669: Theme preview doesn't return theme to normal (h…
fa7944b 
…elix-editor#6694)

* Fix helix-editor#6669: Theme preview doesn't return theme to normal when delete name with Alt-Backspace

* Fix helix-editor#6669: Return theme preview to normal theme for all remaining keybinds that change the promt text
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@h1t
Fix helix-editor#6669: Theme preview doesn't return theme to normal (h…
8c0654e 
…elix-editor#6694)

* Fix helix-editor#6669: Theme preview doesn't return theme to normal when delete name with Alt-Backspace

* Fix helix-editor#6669: Return theme preview to normal theme for all remaining keybinds that change the promt text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

@the-mikedavis the-mikedavis Awaiting requested review from the-mikedavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h1t @pickfire @the-mikedavis