Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for higher F keys to be used #7672

Merged
merged 1 commit into from
Jul 19, 2023
Merged

allow for higher F keys to be used #7672

merged 1 commit into from
Jul 19, 2023

Conversation

christianholman
Copy link
Contributor

As mentioned in #7669, windows allows for higher function keys than F12.
Additionally, custom keyboard firmwares like ZMK support up to F24 https://zmk.dev/docs/codes/keyboard-keypad#f-keys

pascalkuthe
pascalkuthe approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this since I don't use these keys but this seems reasonable to me. I think in the past crossterm didn't support these keys (its in the changelog as new) so that's probably why it was forbidden in the past

@pascalkuthe pascalkuthe added E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-keymap Area: Keymap and keybindings labels Jul 18, 2023
@archseer archseer merged commit 579f68b into helix-editor:master Jul 19, 2023
@archseer archseer mentioned this pull request Jul 19, 2023
Closed
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@christianholman @mtoohey31
allow for higher F keys to be used (helix-editor#7672)
ec6ca3e
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@christianholman
allow for higher F keys to be used (helix-editor#7672)
a349fdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-keymap Area: Keymap and keybindings E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianholman @pascalkuthe @archseer