-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some LSP servers and updated python's roots #7897
Conversation
See https://github.com/razzmatazz/csharp-language-server for more info about it.
It may be prefered than pylsp by someone. According to #5479, I don't make it default for everyone. Just for people who need this.
Using some known filenames to detect correct project root.
Co-authored-by: zetashift <rskaraya@gmail.com>
@oyarsa @zhanghua000 If I don't add:
with a
Then pyright does not work, discussed in #5479 but not really resolved. I spent hours fiddling around with this and still don't really get it. Should we just add |
Yeah I think we should add |
@the-mikedavis How is that done? Adding:
to the main
|
That first change works for me diff --git a/languages.toml b/languages.toml
index 2477f1ad..011ab278 100644
--- a/languages.toml
+++ b/languages.toml
@@ -55,7 +55,7 @@ perlnavigator = { command = "perlnavigator", args= ["--stdio"] }
prisma-language-server = { command = "prisma-language-server", args = ["--stdio"] }
purescript-language-server = { command = "purescript-language-server", args = ["--stdio"] }
pylsp = { command = "pylsp" }
-pyright = { command = "pyright-langserver", args = ["--stdio"] }
+pyright = { command = "pyright-langserver", args = ["--stdio"], config = {} }
pylyzer = { command = "pylyzer", args = ["--server"] }
qmlls = { command = "qmlls" }
r = { command = "R", args = ["--no-echo", "-e", "languageserver::run()"] } where I also have a [[language]]
name = "python"
language-servers = ["pyright"] |
I had a typo, it does indeed work, and I have made a PR #8032 |
* Add csharp-ls for possible c-sharp LSP See https://github.com/razzmatazz/csharp-language-server for more info about it. * Add pyright for possible python LSP It may be prefered than pylsp by someone. According to helix-editor#5479, I don't make it default for everyone. Just for people who need this. * Update roots of python Using some known filenames to detect correct project root. * Add pylyzer for possible python LSP Co-authored-by: zetashift <rskaraya@gmail.com> --------- Co-authored-by: zetashift <rskaraya@gmail.com>
* Add csharp-ls for possible c-sharp LSP See https://github.com/razzmatazz/csharp-language-server for more info about it. * Add pyright for possible python LSP It may be prefered than pylsp by someone. According to helix-editor#5479, I don't make it default for everyone. Just for people who need this. * Update roots of python Using some known filenames to detect correct project root. * Add pylyzer for possible python LSP Co-authored-by: zetashift <rskaraya@gmail.com> --------- Co-authored-by: zetashift <rskaraya@gmail.com>
* Add csharp-ls for possible c-sharp LSP See https://github.com/razzmatazz/csharp-language-server for more info about it. * Add pyright for possible python LSP It may be prefered than pylsp by someone. According to helix-editor#5479, I don't make it default for everyone. Just for people who need this. * Update roots of python Using some known filenames to detect correct project root. * Add pylyzer for possible python LSP Co-authored-by: zetashift <rskaraya@gmail.com> --------- Co-authored-by: zetashift <rskaraya@gmail.com>
roots
for better determination of project rootNote: All LSP servers are not set to default, they are just for people who prefer them.