Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "reset" color value in themes #8083

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Expose "reset" color value in themes #8083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions book/src/themes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ over it and is merged into the default palette.

| Color Name |
| --- |
| `reset` |
Copy link
Contributor

@chtenb chtenb Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the documentation could use a more extensive update.

The default palette uses the terminal's default 16 colors

That does no longer correspond to the list of identiefiers below it. I might send a PR at some point making some clarifications to this documentation chapter in general.

| `black` |
| `red` |
| `green` |
Expand Down
1 change: 1 addition & 0 deletions helix-view/src/theme.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ impl Default for ThemePalette {
fn default() -> Self {
Self {
palette: hashmap! {
"reset".to_string() => Color::Reset,
"black".to_string() => Color::Black,
"red".to_string() => Color::Red,
"green".to_string() => Color::Green,
Expand Down