Add additional YAML injections #8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Sep 9, 2023
runtime/queries/yaml/injections.scm
Outdated
|
|
||
| ;; Github actions ("run") / Gitlab CI ("scripts") | ||
| (block_mapping_pair | ||
| key: (flow_node) @_run (#any-of? @_run "run" "script" "before_script" "after_script") |
There was a problem hiding this comment.
We don't support #any-of?. This will need to be rewritten as a #match?: (#match? @_run "^(run|script|before_script|after_script)$")
There was a problem hiding this comment.
Note: any-of? Was added upstream to tree-sitter now
There was a problem hiding this comment.
Ah yep, once we update tree-sitter we'll have support for #any-of?. The commit we are currently pinned to came right before that change
There was a problem hiding this comment.
I can switch it to match unless tree-sitter is expected to be updated soon?
There was a problem hiding this comment.
We're looking to update again when the next release of tree-sitter gets cut but we're not sure when that will be yet.
For now #match? is good
the-mikedavis
added
S-waiting-on-author
Adds injections for Github Actions and Gitlab CI.
the-mikedavis
approved these changes
Sep 10, 2023
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Sep 10, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds injections for Github Actions & Gitlab CI.
Taken from https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/yaml/injections.scm, which is licensed under Apache-2.0. Let me know if I need to change the license text here :)