Add +N CLI argument to jump to first file's line number #8521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Oct 11, 2023
the-mikedavis
added
C-enhancement
the-mikedavis
changed the title
pascalkuthe
approved these changes
Oct 12, 2023
danillos
pushed a commit
to danillos/helix
that referenced
this pull request
Nov 21, 2023
…#8521) * Accept +num flag for opening at line number * Update +N argument feature according to feedback in original PR helix-editor#5603 * Only override the line number of the first file if +N is specified --------- Co-authored-by: Nachum Barcohen <38861757+nabaco@users.noreply.github.com>
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
…#8521) * Accept +num flag for opening at line number * Update +N argument feature according to feedback in original PR helix-editor#5603 * Only override the line number of the first file if +N is specified --------- Co-authored-by: Nachum Barcohen <38861757+nabaco@users.noreply.github.com>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…#8521) * Accept +num flag for opening at line number * Update +N argument feature according to feedback in original PR helix-editor#5603 * Only override the line number of the first file if +N is specified --------- Co-authored-by: Nachum Barcohen <38861757+nabaco@users.noreply.github.com>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…#8521) * Accept +num flag for opening at line number * Update +N argument feature according to feedback in original PR helix-editor#5603 * Only override the line number of the first file if +N is specified --------- Co-authored-by: Nachum Barcohen <38861757+nabaco@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the PR #5603 has not been updated, I went ahead and fixed the minor feedback from that PR and created a new one. I also fixed an issue making the first file never working with
<file>:<line>as it was overridden.Fixes #5437