Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support strict mode with react v18 #317

Closed
Tracked by #293
100terres opened this issue Apr 10, 2022 · 9 comments · Fixed by #392
Closed
Tracked by #293

Support strict mode with react v18 #317

100terres opened this issue Apr 10, 2022 · 9 comments · Fixed by #392
Assignees
@100terres
Labels
dependencies enhancement New feature or request
Milestone
React v18

Comments

@100terres
Copy link
Collaborator

Related issue from original repo: atlassian/react-beautiful-dnd#2350
@100terres 100terres added enhancement New feature or request dependencies labels Apr 10, 2022
@100terres 100terres added this to the React v18 milestone Apr 10, 2022
@100terres 100terres self-assigned this Apr 10, 2022
This was referenced Apr 10, 2022
Closed
Open
@antoinejaussoin
Copy link

+1 ⭐️

2 similar comments
@nunocaseiro
Copy link

+1 ⭐️

@KatFishSnake
Copy link

+1 ⭐️

@Danzo7
Copy link

Danzo7 commented Jun 20, 2022

+1

@ximex
Copy link

ximex commented Jun 21, 2022

pls don't only add +1 comments. instead add a thumb-up reaction on the first comment

@AntonOfTheWoods
Copy link

Or at the very least ping @100terres directly, so we are sure they see it ;-).

@100terres
Copy link
Collaborator Author

Hi @antoinejaussoin, @nunocaseiro, @KatFishSnake, @Danzo7, @ximex and @AntonOfTheWoods 👋

Thank you for your support.

Sorry for the radio silence 😞

I had some minor health issues and I needed to take a step back from open source development. In the upcoming days/weeks, I'll try to dedicate time in my schedule to make sure @react-forked/dnd support React 18.

@KatFishSnake
Copy link

@100terres if you can break the work down to tasks, I can help you do it, we just did the migration on our codebase so i have some xp

@100terres 100terres mentioned this issue Aug 20, 2022
Merged
@100terres
Copy link
Collaborator Author

100terres commented Aug 21, 2022 •
edited
Loading

Hi everyone 👋

I'll publish later today a veta version supporting react 18 and strict mode.

JinhuiKim added a commit to JinhuiKim/react-todo-app that referenced this issue Sep 23, 2022
@JinhuiKim
Fix: react-beautiful-dnd React v18 StrictMode 모드 미지원
2e8f37c 
- hello-pangea/dnd#293
- hello-pangea/dnd#317

Drag and Drop 기능 추가하기
@paulschreiber paulschreiber mentioned this issue Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@100terres 100terres

Labels
dependencies enhancement New feature or request
Projects
None yet
Milestone
React v18
Development

Successfully merging a pull request may close this issue.

test: run test with react v16 v17 and v18 hello-pangea/dnd
7 participants
@antoinejaussoin @ximex @AntonOfTheWoods @100terres @KatFishSnake @Danzo7 @nunocaseiro