Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React redux v8 #345

Closed
wants to merge 5 commits into from
Closed

React redux v8 #345

wants to merge 5 commits into from

Conversation

rsplithof
Copy link

First of all, thanks for maintaining this package!

When upgrading my app to react-redux to v8 i ran into the following error.

The pure property has been removed in react-redux v8 and will raise the error:
'The `pure` option has been removed. `connect` is now always a "pure/memoized" component'

This PR is an intend to fix this issue when upgrading the react-redux and redux dependencies.

@100terres
Copy link
Collaborator

Hi @rsplithof 🙂

Thank you for opening this PR! I'll have a look at their changelog to see if other things should be changed. I'll also check if this change should be included to the react update.

@paztis
Copy link

paztis commented Apr 29, 2022

When is the migration to react 18 supposed to be released ?

@100terres
Copy link
Collaborator

@paztis I'm still on the case. I also need this migration to react v18 for one of my project. I have no timeline yet, but I'm trying to release it as soon as possible! 🙂

@paztis
Copy link

paztis commented May 13, 2022

I've created this small PR #373 to avoid to block user migration until your real PR is merged.

@100terres
Copy link
Collaborator

@paztis @rsplithof we'll soon release a new version that support react 18 and uses react-redux 8 internally. Here's the commit 93cc3d5

I'll close this PR and keep you posted once it's released 🙂

@100terres 100terres closed this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants