Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LightControl message #138

Merged
merged 3 commits into from
Dec 1, 2016
Merged

Add LightControl message #138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a69a6d8
Add LightControl message
Nov 30, 2016
909c449
Simplify
Dec 1, 2016
71ed229
Rename
Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions messeji/audio_commands.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,12 @@ message Volume {
message VoiceControl {
required bool enable = 1;
}

message LightControl {
enum Method {
POST = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hue uses PUT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to let the body include the http headers, so this only needs the IP and the blob to send there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plasticchris do you mean generating the entire socket stream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reuse this message to post anything anywhere... good for botnets

}
required string url = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#define HOST_LEN 32
#define PATH_LEN 64

FW has a limit on how long host and path can be. might be a good idea to cap them as an option.

required bytes body = 2;
required Method http_method = 3;
}