Changed graph look. [ref #107442248] #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -348,7 +348,7 @@ public void onGraphHighlightBegin() { | |||
| @Override | |||
| public void onGraphValueHighlighted(int section, int position) { | |||
| final SensorGraphSample instant = getSection(section).get(position); | |||
| if (instant.isValuePlaceholder()) { | |||
| if (instant.isValuePlaceholder() || instant.getValue() == 0) { | |||
There was a problem hiding this comment.
0 does not indicate a missing value – this would produce an incorrect reading on a room with 0 lux or 0 dB
returning the missing value sentinel (-1) is currently feature gated in the backend
|
multiplying the minY value will probably present problems later on. since we aren't drawing any headers and footers anymore, you can remove the implementation of |
zafrani
added a commit
that referenced
this pull request
Nov 20, 2015
Changed graph look. [ref #107442248]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: https://www.pivotaltracker.com/story/show/107442248
Spoke to @keussen and we decided to change the original design. Instead of using dotted line where data isn't captured, instead lower the entire graph so the line representing no data is sitting at the bottom of the screen. Also use the placeholder text value for those locations when the user touches the graph.