fix: use custom Exception

hellokitty-coding-club · Jul 20, 2023 · 0a5f85b · 0a5f85b
1 parent 4a3e2b1
commit 0a5f85b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/API-Server/src/main/java/swm/hkcc/LGTM/app/modules/auth/exception/InvalidAuthentication.java b/API-Server/src/main/java/swm/hkcc/LGTM/app/modules/auth/exception/InvalidAuthentication.java
@@ -0,0 +1,10 @@
+package swm.hkcc.LGTM.app.modules.auth.exception;
+
+import swm.hkcc.LGTM.app.global.constant.ResponseCode;
+import swm.hkcc.LGTM.app.global.exception.GeneralException;
+
+public class InvalidAuthentication extends GeneralException {
+    public InvalidAuthentication() {
+        super(ResponseCode.INVALID_AUTHENTICATION);
+    }
+}
diff --git a/...rver/src/main/java/swm/hkcc/LGTM/app/modules/member/service/CustomUserDetailsService.java b/...rver/src/main/java/swm/hkcc/LGTM/app/modules/member/service/CustomUserDetailsService.java
@@ -7,6 +7,7 @@
 import org.springframework.security.core.userdetails.UserDetailsService;
 import org.springframework.security.core.userdetails.UsernameNotFoundException;
 import org.springframework.stereotype.Service;
+import swm.hkcc.LGTM.app.modules.auth.exception.InvalidAuthentication;
 import swm.hkcc.LGTM.app.modules.member.domain.Member;
 import swm.hkcc.LGTM.app.modules.member.domain.custom.CustomUserDetails;
 import swm.hkcc.LGTM.app.modules.member.repository.MemberRepository;
@@ -20,9 +21,8 @@ public class CustomUserDetailsService implements UserDetailsService {
     @Override
     public UserDetails loadUserByUsername(String githubId) throws UsernameNotFoundException {
         log.info("username: " + githubId);
-        Member member = memberRepository.findOneByGithubId(githubId).orElseThrow(
-                () -> new UsernameNotFoundException("Invalid authentication!")
-        );
+        Member member = memberRepository.findOneByGithubId(githubId)
+                .orElseThrow(InvalidAuthentication::new);
 
         return new CustomUserDetails(member);
     }