Ignore directories with missing Chart.yaml #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example test run here: https://github.com/ccremer/charts/runs/531250478?check_suite_focus=true - name: Run chart-releaser
uses: ccremer/chart-releaser-action@ignore-dirs
env:
CR_TOKEN: "${{ secrets.CR_TOKEN }}"
with:
charts_dir: .Log: |
unguiculus
requested changes
Apr 4, 2020
|
Thanks for the review! I updated my commit. |
unguiculus
reviewed
Apr 4, 2020
scottrigby
reviewed
Apr 5, 2020
Prevents action fails when there are directories detected that do not contain charts. (e.g. .github) Signed-off-by: Chris <github.account@chrigel.net>
|
Added your suggestions. Looking up latest tag...
Discovering changed charts since 'znapzend-0.3.1'...
WARNING: .github/Chart.yaml is missing, assuming that '.github' is not a Helm chart. Skipping.
Installing chart-releaser...
Packaging chart 'znapzend'...
Successfully packaged chart and saved it to: .cr-release-packages/znapzend-0.3.1.tgz
Releasing charts... |
scottrigby
approved these changes
Apr 6, 2020
|
I added a fixes comment to the description above to automatically close related issue on PR merge |
unguiculus
approved these changes
Apr 6, 2020
|
Would be nice to have a with:
charts_dir: .... this fails |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents action fails when there are directories detected that do not contain charts (e.g.
.github)as proposed in #12
feedback welcome
fixes #12