Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action version in README #59

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Fix action version in README #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67d83e8
Fix action version in README
JGiola Nov 6, 2020
fd26020
Update README.md
unguiculus Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ A GitHub action to turn a GitHub project into a self-hosted Helm chart repo, usi

For more information on inputs, see the [API Documentation](https://developer.github.com/v3/repos/releases/#input)

- `version`: The chart-releaser version to use (default: v1.1.1)
- `version`: The chart-releaser version to use (default: v1.1.0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t get why change this version, the default cart-releaser version used is the v1.1.1, is only the chart-releaser-action version used that was wrong because it wasn’t released already, or I’m missing something?

- `config`: Optional config file for chart-releaser
- `charts_dir`: The charts directory
- `charts_repo_url`: The GitHub Pages URL to the charts repo (default: `https://<owner>.github.io/<project>`)
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
version: v3.4.0

- name: Run chart-releaser
uses: helm/chart-releaser-action@v1.1.1
uses: helm/chart-releaser-action@v1.1.0
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
```
Expand Down