-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to host the chart package files in the GitHub Pages branch #123
Conversation
@stecky thanks for this PR, can you please sign the DCO and add some tests for this change? thanks! |
d9f3e57
to
7dd9935
Compare
ok @cpanato I signed the DCO and added some tests |
b25248a
to
a9e797b
Compare
1ee473b
to
6269474
Compare
I added a patch to the PR to use the token passed in to authenticate to the repo when checking for an existing index.yaml |
Is it planned to be merged? It would be great to start using it. |
Is it merging anytime soon? |
@davidkarlsen I am also waiting on this functionality. Looks like a review is required to complete the merge. |
@cpanato any chance of merging it? |
Just hit this issue also, would love to see this merged |
will add this to my backlog to perform some manual tests and check. meantime @davidkarlsen @unguiculus @scottrigby any thoughts? |
Just to bare in mind I found an issue with this approach while testing on the branched repository. |
I find this overly complex. I am able to use this application (through the action) as follows:
|
When its done, Please add an example on how to use it . Thanks :) |
When merge it ? we really need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some documentation to explain how to use that?
thanks for this PR
Also hitting this as a blocker in our private repository. Anything I can help with to get this merged? |
I am also waiting for this PR as I'm unable to use this tool currently. |
for the time being use stecky/yet-another-chart-releaser-action@v1 - works perfect for me - THX @stecky - name: Run chart-releaser
uses: stecky/yet-another-chart-releaser-action@v1
with:
packages_with_index: true
env:
YACR_TOKEN: "${{ secrets.GITHUB_TOKEN }}" |
Great thank you! And https://github.com/stecky/yet-another-chart-releaser already has documentation |
The solution from stecky works great (thank you stecky), but this is clearly an in-demand feature that should be supported by the official Helm implementation. Taking a core dependency on a fork of an official release branch in someone's personal github is at best a risky solution for anyone, and at worst a disaster for anyone who relies on this and the personal account decides to delete their repo/fork. So I will ask again: is there anything I can do to facilitate and help get this PR merged so we can all use the official Helm chart releaser? |
Thanks to all who have been working on this thus far. Would love to have this fix merged in ASAP. Hopefully I can schedule some time in my day to look into this as well. |
Got hung up on needing to set my go path on this new laptop. 🙄 Pasting here in case someone else needs that info as well.
Replicated the same issue that @jgiretimhaus was having. I'll look more today to see if I can find a resolution. |
@jgiretimhaus you need to add
my |
Hey @sconnole ! I was away for work yesterday and didn't see your ping. But god damn was I happy this morning ahaha ! I tried adding the --push flag in the upload method and it worked as expected. I was sure it was something like that :) Thanks a lot for taking the time to test it and finding the flag I was missing ! Here is my github-pages branch : And my updated Really excited to finally get this feature added ! Bravo to everyone that worked on this ! @cpanato can we expect a merge and a release in the coming week ? |
Hi @cpanato ! Thanks again for your work. Do you have any release date for this feature please ? |
Hi, sorry for being insistent :-) trying to get any news from @cpanato |
Hello @cpanato, sorry to ping you again as I am sure that you already have plenty on your plate but this feature would be a game changer for us and it is so close to completion, requiring only a merge that it would be a shame if the issue became stale again. Many thanks again ! |
Any news when we could expect this to be merged? |
Signed-off-by: Steven Barnes <Steven.Barnes@topgolf.com>
Signed-off-by: Steven Barnes <Steven.Barnes@topgolf.com>
Signed-off-by: Steven Barnes <Steven.Barnes@topgolf.com>
Signed-off-by: Steven Barnes <Steven.Barnes@topgolf.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
5f864f8
to
1ff032d
Compare
Signed-off-by: cpanato <ctadeu@gmail.com>
1ff032d
to
90859b0
Compare
Signed-off-by: cpanato <ctadeu@gmail.com>
@jgiretimhaus @edijsdrezovs funny image :) but I am a bit on the fence about merging this, but let's do that, I did some manual tests, and it seems to work and not break the existing behavior. |
Hey, @cpanato-Kenobi ^^ ! Thanks a lot for the big push ! Do you have a specific part of the PR that worries you or do you expect any unwanted behavior that we should look out for and report ? As we keep testing and start bringing this to our production slowly ofc so we can monitor this, I'll be sure to let you guys know if we encounter any problem, here, in this thread. We should maybe still keep the issue open a bit as we let's say beta test this in production for a month maybe ? Will the chart-releaser-action be updated when the merge passes ? Awesome work and thanks again to you and @stecky for bringing this feature to the community ! Cheers ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
chart-releaser can run in several modes now, so maybe we should add some more docs in the readme to verbose those usages out - but that can be added later on, as this change is backwards compatible.
@jgiretimhaus @edijsdrezovs looks like you both are the most interested in this feature. Can I have a commitment from all of you to create/update/add some documentation to cover both flows? as @davidkarlsen points out? if you agree, we can merge this with a promise that we will have some documentation. wdyt? |
I'm also interested so maybe I can help with a PR in some time. |
Of course :) ! I should have some time today, I'll try to start a nice little verbose documentation today I'll keep you updated |
Hey ! I was able to work on it today. I added a section about the usage of the --package-with-index flag and an example reusing the screenshots I took while testing this PR. I also added a Common Error Messages section as I encountered a 422 Validation Failed while retesting the whole process to make sure the process described in the documentation was working as intended. It is solved using the --skip-existing flag. Btw, you could close issue #101 as it is solved in #111 that adds the --skip-existing flag. Tell me if I should update/remove/add something so it fits better. My PR is here and DCO is signed :) Looking forward to the merge. Cheers ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
When using this tool on a private repo, helm is unable to download the chart package files. When you give Helm your username and password it uses it to authenticate to the repository (the index file). The index file then tells Helm where to get the tarball. If the tarball is hosted in some other location (Github Releases in this case) then it would require a second authentication (which Helm does not support). The solution is to host the files in the same place as your index file and make the links relative paths so there is no need for the second authentication. This PR adds a flag (
--packages-with-index
) to the upload and index commands to accomplish this. It would resolve #115