feat: add option to disable blob verification #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
|
If desired i can add a github wf test - just let me know |
cpanato
requested changes
Oct 31, 2023
As from cpanato suggested the installation of cosign should be skipped. Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
fty4
force-pushed
the
feat/verify-blob
branch
from
3bf8415
to
3cd4d56
Compare
|
@cpanato Added the requested changes |
cpanato
reviewed
Oct 31, 2023
cpanato
reviewed
Oct 31, 2023
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
The name of the test_ct_action_noverify test did not receive any customizing for the name. No there is a unique name to describe what is tested. Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Adding messages to determinate if blob was verified. Also moving Install message out of verify if statement Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Updating version required after merging main to PR. Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
|
@cpanato All requests are now implemented. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the issue that the address
sigstore.devis not shared on my runner (we do not like to open it).So i would like to disable the verification by option.
Therefore I created a input to disable the verification in the action.
With the default Action configuration the sensible verification is enabled for sure.