Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup env regardless if tool was fresh installed or existed. Fixes #62 #63

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Nov 12, 2020

Signed-off-by: David Karlsen david@davidkarlsen.com


This change is Reviewable

…m#62

Signed-off-by: David Karlsen <david@davidkarlsen.com>
@davidkarlsen davidkarlsen changed the title setup env regardless if tool was freshinstalled or existed. Fixes #62 setup env regardless if tool was fresh installed or existed. Fixes #62 Nov 12, 2020
@davidkarlsen davidkarlsen linked an issue Nov 12, 2020 that may be closed by this pull request
Copy link
Member

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks. Just one remark. Otherwise LGTM.

ct.sh Outdated Show resolved Hide resolved
Signed-off-by: David Karlsen <david@davidkarlsen.com>
@davidkarlsen davidkarlsen merged commit cc029d9 into helm:master Nov 13, 2020
@davidkarlsen davidkarlsen deleted the issue62 branch November 13, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needs to add ct to path regardless if it was installed or not
3 participants