Add versioning policies to review guidelines

Fixes #5657 Signed-off-by: Scott Rigby <scott@r6by.com>
helm · Feb 6, 2019 · 213d3ab · 213d3ab
1 parent 0041f31
commit 213d3ab
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/REVIEW_GUIDELINES.md b/REVIEW_GUIDELINES.md
@@ -16,6 +16,17 @@ Note, if a reviewer who is not an approver in an OWNERS file leaves a comment of
 
 Chart releases must be immutable. Any change to a chart warrants a chart version bump even if it is only changes to the documentation.
 
+## Versioning
+
+The chart `version` should follow [semver](https://semver.org/).
+
+Stable charts should start at `1.0.0` (for maintainability don't create new PRs for stable charts only to meet this criteria, but when reviewing PRs take the opportunity to ensure that this is met).
+
+Any breaking (backwards incompatible) changes to a chart should:
+
+1. Bump the MAJOR version
+2. In the README, under a section called "Upgrading", describe the manual steps necessary to upgrade to the new (specified) MAJOR version
+
 ## Chart Metadata
 
 The `Chart.yaml` should be as complete as possible. The following fields are mandatory: