Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cockroachdb] StatefulSet upgrade fails because of chart label present in selector #8102

Closed
rio opened this issue Oct 2, 2018 · 1 comment · Fixed by #8109
Closed

[stable/cockroachdb] StatefulSet upgrade fails because of chart label present in selector #8102

rio opened this issue Oct 2, 2018 · 1 comment · Fixed by #8109

Comments

@rio
Copy link
Contributor

rio commented Oct 2, 2018

Just like with the redis chart StatefulSet upgrades fail through the helm upgrade mechanism. This is because no explicit selector is set on the StatefulSet so it defaults to whatever is set in the template's labels. This includes the chart version which changes with every upgrade. Because the selector cannot be changed after the creation of the StatfulSet the upgrade fails because the template's chart label does get updated and so the selector doesn't match anymore.

This is how the redis chart fixed it: c3bbcad#diff-bff5387866dba6e2bb69e1feba09ea9b

Sadly this would mean a breaking change to the chart and downtime as the StatefulSet needs to be deleted.
@rio rio changed the title [stable/cockroachdb] StatefulSet upgrade failes because of chart label present in selector [stable/cockroachdb] StatefulSet upgrade fails because of chart label present in selector Oct 2, 2018
@rio
Copy link
Contributor Author

rio commented Oct 2, 2018

For reference here is the general problem described #7680

@rio rio mentioned this issue Oct 2, 2018
Merged
3 tasks
k8s-ci-robot pushed a commit that referenced this issue Oct 4, 2018
@rio @k8s-ci-robot
fix(stable/cockroachdb): Add an explicit selector to the StatefulSet (#…
85cddea 
…8109)

This was preventing any upgrades because kubernetes made the selector
immutable and the chart version changes between upgrades of charts.

fix #8102

Signed-off-by: Rio Kierkels <riokierkels@gmail.com>
darioblanco pushed a commit to minddocdev/charts that referenced this issue Oct 22, 2018
@rio
fix(stable/cockroachdb): Add an explicit selector to the StatefulSet (h…
abe6645 
…elm#8109)

This was preventing any upgrades because kubernetes made the selector
immutable and the chart version changes between upgrades of charts.

fix helm#8102

Signed-off-by: Rio Kierkels <riokierkels@gmail.com>
Jnig pushed a commit to Jnig/charts that referenced this issue Nov 13, 2018
@rio @Jnig
fix(stable/cockroachdb): Add an explicit selector to the StatefulSet (h…
42c0c8e 
…elm#8109)

This was preventing any upgrades because kubernetes made the selector
immutable and the chart version changes between upgrades of charts.

fix helm#8102

Signed-off-by: Rio Kierkels <riokierkels@gmail.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this issue Jan 18, 2019
@rio @wgiddens
fix(stable/cockroachdb): Add an explicit selector to the StatefulSet (h…
4fcad10 
…elm#8109)

This was preventing any upgrades because kubernetes made the selector
immutable and the chart version changes between upgrades of charts.

fix helm#8102

Signed-off-by: Rio Kierkels <riokierkels@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stable/cockroachdb): Add an explicit selector to the StatefulSet rio/charts
1 participant
@rio