Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mongodb] Fix chart not being upgradable when replicaset is enabled. #10121

Merged
merged 1 commit into from
Dec 19, 2018
Merged

[stable/mongodb] Fix chart not being upgradable when replicaset is enabled. #10121

merged 1 commit into from
Dec 19, 2018

Conversation

juan131
Copy link
Collaborator

@juan131 juan131 commented Dec 19, 2018

Signed-off-by: juan131 juan@bitnami.com

What this PR does / why we need it:

This PR fixes a known issue to upgrade the chart when deployment/statefulsets contain labels that depend on the chart's version.

Which issue this PR fixes

…abled.

Signed-off-by: juan131 <juan@bitnami.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2018
Copy link
Collaborator

@tompizmor tompizmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2018
@juan131
Copy link
Collaborator Author

juan131 commented Dec 19, 2018

/assign @desaintmartin

@k8s-ci-robot k8s-ci-robot merged commit de58914 into helm:master Dec 19, 2018
@juan131 juan131 deleted the mongodb_upgrade branch December 19, 2018 08:25
@desaintmartin
Copy link
Collaborator

Nice, thanks!

coreypobrien pushed a commit to FairwindsOps/helm-charts that referenced this pull request Dec 31, 2018
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants