helm lamp stack chart #1288

fnerdman · 2017-06-13T12:01:33Z

See lamp/README.md for details of the chart. Let me know if you have any suggestions to complete the pull request.

viglesiasce · 2017-07-05T21:24:09Z

viglesiasce · 2017-07-05T21:56:08Z

/test

viglesiasce · 2017-07-05T21:57:32Z

Can you add a default PW for the mysql like in the MySQL chart? This will allow the chart to install with the default values and make CI go through.

Example:
https://github.com/ROKKYT1/charts/blob/445ccf8418f19e258c54514eec5be773b1219401/stable/mysql/templates/secrets.yaml#L12

viglesiasce · 2017-07-05T21:57:42Z

BTW awesome chart!!!!!!

viglesiasce

Make a default PW (hopefully random) for the MySQL root PW.

fnerdman · 2017-07-15T07:38:30Z

@viglesiasce
Random password is not a good idea. I've run into a lot of problems because updating the release would reset the password and then things like cloning the release would not work anymore. I've disabled the mysql container by default and now the build finishes successfully.

fnerdman · 2017-07-15T07:39:52Z

/retest

…ependency removed by adding the httpd config files to the chart

fnerdman · 2017-08-08T10:42:55Z

@viglesiasce I'd like to contribute a 'nextcloud' chart which uses the lamp chart as a dependency. How long will it take to accept this pull request?

unguiculus

Please have a look at our best practices, especially regarding standard labels. Make sure all resources get our standard labels.
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/labels.md

Note that we've started namespacing template (see #1785). Please apply this to your chart.

Please update the PR with latest master.

unguiculus · 2017-11-03T16:27:30Z

stable/lamp/Chart.yaml

+apiVersion: v1
+description: Modular and transparent LAMP stack chart supporting PHP-FPM, Release Cloning, LoadBalancer, Ingress, SSL and lots more!
+name: lamp
+version: 0.1.0


Add appVersion.

We can leave this off since there is a conglomeration of app versions.

unguiculus · 2017-11-03T16:28:05Z

stable/lamp/README.md

+
+## Prerequisites
+
+- Kubernetes 1.4+ with Beta APIs enabled


unguiculus · 2017-11-03T16:34:35Z

stable/lamp/templates/deployment.yaml

+    metadata:
+      labels:
+        app: {{ template "fullname" . }}
+      annotations:


Use initContainers field on the PodSpec instead of annotation.

unguiculus · 2017-11-03T16:35:50Z

stable/lamp/templates/ingress.yaml

@@ -0,0 +1,126 @@
+{{- if .Values.ingress.enabled -}}


One file per resource, please.

unguiculus · 2017-11-03T16:38:45Z

stable/lamp/templates/ingress.yaml

+kind: Ingress
+metadata:
+  name: {{ template "fullname" . }}-www
+  annotations:


Instead of wrapping various annotations in if blocks, I'd suggest you add the annotations to the configuration. This would also be more flexible.

unguiculus · 2017-11-03T16:40:50Z

stable/lamp/templates/pvc.yaml

+    heritage: "{{ .Release.Service }}"
+  {{- if .Values.persistence.storageClass }}
+  annotations:
+    volume.beta.kubernetes.io/storage-class: {{ .Values.persistence.storageClass | quote }}


No longer use annotation for storage class. We've developed a pattern for persistence (see #1869). Please follow this approach.

unguiculus · 2017-11-03T16:41:23Z

stable/lamp/templates/service.yaml

+{{- if and .Values.sftp.enabled .Values.ingress.enabled }}
+
+---
+


One file per resource, please.

unguiculus · 2017-11-03T16:41:55Z

stable/lamp/values.yaml

+  #repository: php
+  #tag: fpm
+  pullPolicy: Always
+  fpm_enabled: true


Use camel case instead of underscores. Apply everywhere.

unguiculus · 2017-11-16T20:28:26Z

Marking this as stale. Please update within one week.

fnerdman · 2017-11-17T18:45:07Z

@unguiculus
I've fixed almost all of the issues. There are two things to note:

appVersion: since there are different "apps" being used, such as php, mysql etc. and the versions can change via values, i wouldn't know which one to chose
I added custom annotations to ingress however some of the annotations inside if clauses i left since they access template variables / have a broader spectrum and need more logic elsewhere

unguiculus · 2017-11-17T20:37:47Z

stable/lamp/templates/configmap-httpd.yaml

+metadata:
+  name: {{ template "lamp.fullname" . }}-httpd
+  labels:
+    app: {{ template "lamp.fullname" . }}


Should be app: {{ template "lamp.name" . }}. Please update everywhere.

unguiculus · 2017-11-17T20:38:56Z

stable/lamp/templates/service-sftp.yaml

+    protocol: TCP
+    name: sftp
+  selector:
+    app: {{ template "lamp.fullname" . }}


Add release label to selector.

unguiculus · 2017-11-17T20:40:11Z

stable/lamp/templates/service.yaml

+    name: phpmyadmin
+  {{ end }}
+  selector:
+    app: {{ template "lamp.fullname" . }}


Add release label to selector.

fnerdman · 2017-11-17T21:08:22Z

@unguiculus updated

unguiculus · 2017-11-23T20:24:24Z

@viglesiasce Could you have another look, please?

viglesiasce · 2017-11-27T17:39:07Z

stable/lamp/Chart.yaml

+apiVersion: v1
+description: Modular and transparent LAMP stack chart supporting PHP-FPM, Release Cloning, LoadBalancer, Ingress, SSL and lots more!
+name: lamp
+version: 0.1.0


We can leave this off since there is a conglomeration of app versions.

viglesiasce · 2017-11-27T17:41:14Z

stable/lamp/values.yaml

+  ## `ingress.kubernetes.io/proxy-body-size
+  annotations:
+    ingress.kubernetes.io/proxy-body-size: "50m"
+    kubernetes.io/ingress.class: nginx


Should leave these commented so that you can use the default ingress in the cluster, unless the proxy-body-size and NGINX is required.

Indeed, nginx ingress controller is not mandatory although some features such as ssl are only working with nginx controller. I've commented that part out and added explanations regarding nginx controller requirements to the values which need the controller.

viglesiasce · 2017-11-27T17:41:51Z

/ok-to-test

viglesiasce · 2017-11-27T19:56:54Z

awesome in that case:

/lgtm

@unguiculus all set on my end, merge when you are ready

lamp stack released for pull request

c6e92f0

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2017

bugfixing hostPath and persitent subpath features

445ccf8

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2017

viglesiasce self-requested a review July 5, 2017 21:57

viglesiasce suggested changes Jul 5, 2017

View reviewed changes

disabled mysql by default

00ac0f9

mysql root password enables mysql container and lead4good/httpd-fpm d…

a5fa032

…ependency removed by adding the httpd config files to the chart

disabled deleting uploads directory in wp develop environment by default

d72622f

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 12, 2017

lead4good added 2 commits September 25, 2017 13:38

fix configmap bug

a37f3ff

mysql password bug

e38b62d

unguiculus suggested changes Nov 3, 2017

View reviewed changes

unguiculus self-assigned this Nov 3, 2017

unguiculus added the stale label Nov 16, 2017

lead4good added 6 commits November 17, 2017 10:46

Merge branch 'master' of https://github.com/kubernetes/charts

84e4e0f

moved init containers from beta annotation into spec

47a2c69

split up ingress file and added custom annotations

bac65c5

moved storage class annotation to stable

922f989

split up service.yaml

4532fe7

camel casing variables

b53b9b4

lead4good added 5 commits November 17, 2017 18:19

namespace defined templates

f0665f0

values.yaml best practice

cf543a6

labels best practice

0e81f36

fixed ingress annotations

3b29dab

fixed forgotten fullname helper

7a334c6

unguiculus removed the stale label Nov 17, 2017

unguiculus suggested changes Nov 17, 2017

View reviewed changes

updated app labels and service selector release labels

e51d0f5

viglesiasce suggested changes Nov 27, 2017

View reviewed changes

lead4good added 2 commits November 27, 2017 20:29

commented nginx specific ingress annotations

33608d3

linter error: removed empty line

38ac13a

k8s-ci-robot assigned viglesiasce Nov 27, 2017

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2017

viglesiasce approved these changes Nov 27, 2017

View reviewed changes

unguiculus approved these changes Dec 5, 2017

View reviewed changes

unguiculus merged commit d284317 into helm:master Dec 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

helm lamp stack chart #1288

helm lamp stack chart #1288

fnerdman commented Jun 13, 2017

viglesiasce commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

viglesiasce left a comment

fnerdman commented Jul 15, 2017

fnerdman commented Jul 15, 2017

fnerdman commented Aug 8, 2017

unguiculus left a comment

unguiculus Nov 3, 2017

viglesiasce Nov 27, 2017

unguiculus Nov 3, 2017

unguiculus Nov 3, 2017

unguiculus Nov 3, 2017

unguiculus Nov 3, 2017

unguiculus Nov 3, 2017

unguiculus Nov 3, 2017

unguiculus Nov 3, 2017

unguiculus commented Nov 16, 2017

fnerdman commented Nov 17, 2017

unguiculus Nov 17, 2017

unguiculus Nov 17, 2017

unguiculus Nov 17, 2017

fnerdman commented Nov 17, 2017

unguiculus commented Nov 23, 2017

viglesiasce Nov 27, 2017

viglesiasce Nov 27, 2017

fnerdman Nov 27, 2017

viglesiasce commented Nov 27, 2017

viglesiasce commented Nov 27, 2017

		{{- if and .Values.sftp.enabled .Values.ingress.enabled }}

		---

helm lamp stack chart #1288

helm lamp stack chart #1288

Conversation

fnerdman commented Jun 13, 2017

viglesiasce commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

viglesiasce left a comment

Choose a reason for hiding this comment

fnerdman commented Jul 15, 2017

fnerdman commented Jul 15, 2017

fnerdman commented Aug 8, 2017

unguiculus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unguiculus commented Nov 16, 2017

fnerdman commented Nov 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fnerdman commented Nov 17, 2017

unguiculus commented Nov 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viglesiasce commented Nov 27, 2017

viglesiasce commented Nov 27, 2017